Fly Deploy並列実行による失敗をマージキューで防ぐ

[yonta]

fix #615

やったこと

• pushトリガーでのActions起動を削除した
  • そもそも必要ない
  • マージキュー化で邪魔なので削除
  • ついでにこれにより入れていたskip-duplicate-actionsも削除した
• FlyへのデプロイをGitHubマージキューで行うようにした
• Actionsのconccurency設定をして、Flyへのデプロイを同時に1つまでに制限した
• ちょっとしたリファクタ

参考資料

• GitHub Actions doc
  • https://docs.github.com/ja/actions/using-jobs/using-concurrency
• Fly doc
  • https://fly.io/docs/app-guides/continuous-deployment-with-github-actions/

以下古い内容

必要な追加作業

1. ベースブランチの保護ルールで「マージキューを必須にする」
2. マージの制限、の、マージする pull request の最大数、を「1」にする
3. 他はデフォルトでよさそう？たぶん

• レポジトリオーナーのももかすにしかできない
• ドキュメント
  • https://docs.github.com/ja/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#managing-a-merge-queue

今後どうなるか

• 「Merge pull request」ボタンが「Merge when ready」ボタンに変わるらしい！
• ドキュメント
  • https://docs.github.com/ja/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request-with-a-merge-queue

[github-actions]

📦 esbuild Bundle Analysis for sakazuki

This analysis was generated by esbuild-bundle-analyzer. 🤖

Meta File	Out File	Size (raw)	Note
meta.json	app/assets/builds/application.js	1.01 MB	🆕 Added

Largest paths

These visualization shows top 20 largest paths in the bundle.

Meta file: meta.json, Out file: app/assets/builds/application.js

Path	Size
node_modules/chart.js/dist	${{\color{Goldenrod}{ ██████▊ }}}$ 27.4%, 273.88 KB
app/javascript/completion	${{\color{Goldenrod}{ ████▎ }}}$ 17.1%, 170.67 KB
node_modules/@hotwired/turbo	${{\color{Goldenrod}{ ███▎ }}}$ 13.2%, 131.96 KB
node_modules/bootstrap/dist	${{\color{Goldenrod}{ ███ }}}$ 12.4%, 124.34 KB
node_modules/simplelightbox/dist	${{\color{Goldenrod}{ ██▏ }}}$ 8.8%, 87.73 KB
node_modules/@hotwired/stimulus	${{\color{Goldenrod}{ ██ }}}$ 8.4%, 84.29 KB
node_modules/@popperjs/core	${{\color{Goldenrod}{ █▍ }}}$ 5.6%, 55.66 KB
node_modules/@rails/actioncable	${{\color{Goldenrod}{ ▌ }}}$ 2.0%, 19.51 KB
node_modules/rater-js/index.js	${{\color{Goldenrod}{ ▍ }}}$ 1.6%, 16.42 KB
node_modules/@kurkle/color	${{\color{Goldenrod}{ ▎ }}}$ 1.3%, 13.37 KB
app/javascript/taste_graph	${{\color{Goldenrod}{ ▏ }}}$ 0.8%, 7.56 KB
app/javascript/controllers	${{\color{Goldenrod}{ ▏ }}}$ 0.7%, 7.12 KB
node_modules/@hotwired/turbo-rails	${{\color{Goldenrod}{ }}}$ 0.4%, 3.82 KB
node_modules/ts-deepmerge/esm	${{\color{Goldenrod}{ }}}$ 0.2%, 1.69 KB
node_modules/just-zip-it/index.mjs	${{\color{Goldenrod}{ }}}$ 0.1%, 785 B
node_modules/chart.js/helpers	${{\color{Goldenrod}{ }}}$ 0.0%, 0 B
app/javascript/application.js	${{\color{Goldenrod}{ }}}$ 0.0%, 0 B

Details

Next to the size is how much the size has increased or decreased compared with the base branch of this PR.

• ‼️: Size increased by 20% or more. Special attention should be given to this.
• ⚠️: Size increased in acceptable range (lower than 20%).
• ✅: No change or even downsized.
• 🗑️: The out file is deleted: not found in base branch.
• 🆕: The out file is newly found: will be added to base branch.

[momocus]

merge queを利用するにはGithub Enterpriseの契約（月21ドル）が必要なのでダメです🙅‍♀️

[yonta]

ぐえー。
コンカレンシーで防げるらしいので、そっちに変更しよう。

[yonta]

はーん、答えは2行だった