Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

まだレビューされてない酒がすべて炭酸なしになるのを修正 #744

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

yonta
Copy link
Collaborator

@yonta yonta commented Jun 30, 2024

close #742

やったこと

  • 酒ビューにて炭酸の文字列が空のとき炭酸なしと補完するのをやめた
  • 酒フォームの炭酸項目に選択肢を追加した

@github-actions github-actions bot requested a review from momocus June 30, 2024 09:50
Copy link

github-actions bot commented Jun 30, 2024

📦 esbuild Bundle Analysis for sakazuki

This analysis was generated by esbuild-bundle-analyzer. 🤖

Meta File Out File Size (raw) Note
meta.json app/assets/builds/application.js 1.01 MB 🆕 Added
Largest paths These visualization shows top 20 largest paths in the bundle.

Meta file: meta.json, Out file: app/assets/builds/application.js

Path Size
node_modules/chart.js/dist ${{\color{Goldenrod}{ ██████▊ }}}$ 27.4%, 273.88 KB
app/javascript/completion ${{\color{Goldenrod}{ ████▎ }}}$ 17.1%, 170.75 KB
node_modules/@hotwired/turbo ${{\color{Goldenrod}{ ███▎ }}}$ 13.2%, 131.96 KB
node_modules/bootstrap/dist ${{\color{Goldenrod}{ ███ }}}$ 12.4%, 124.34 KB
node_modules/simplelightbox/dist ${{\color{Goldenrod}{ ██▏ }}}$ 8.8%, 87.73 KB
node_modules/@hotwired/stimulus ${{\color{Goldenrod}{ ██ }}}$ 8.4%, 84.29 KB
node_modules/@popperjs/core ${{\color{Goldenrod}{ █▍ }}}$ 5.6%, 55.66 KB
node_modules/@rails/actioncable ${{\color{Goldenrod}{ ▌ }}}$ 2.0%, 19.51 KB
node_modules/rater-js/index.js ${{\color{Goldenrod}{ ▍ }}}$ 1.6%, 16.42 KB
node_modules/@kurkle/color ${{\color{Goldenrod}{ ▎ }}}$ 1.3%, 13.37 KB
app/javascript/taste_graph ${{\color{Goldenrod}{ ▏ }}}$ 0.8%, 7.56 KB
app/javascript/controllers ${{\color{Goldenrod}{ ▏ }}}$ 0.7%, 7.12 KB
node_modules/@hotwired/turbo-rails ${{\color{Goldenrod}{ }}}$ 0.4%, 3.82 KB
node_modules/ts-deepmerge/esm ${{\color{Goldenrod}{ }}}$ 0.2%, 1.69 KB
node_modules/just-zip-it/index.mjs ${{\color{Goldenrod}{ }}}$ 0.1%, 785 B
node_modules/chart.js/helpers ${{\color{Goldenrod}{ }}}$ 0.0%, 0 B
app/javascript/application.js ${{\color{Goldenrod}{ }}}$ 0.0%, 0 B
Details

Next to the size is how much the size has increased or decreased compared with the base branch of this PR.

  • ‼️: Size increased by 20% or more. Special attention should be given to this.
  • ⚠️: Size increased in acceptable range (lower than 20%).
  • ✅: No change or even downsized.
  • 🗑️: The out file is deleted: not found in base branch.
  • 🆕: The out file is newly found: will be added to base branch.

@yonta yonta force-pushed the pr/issue742/no-tansan branch from 3cb9dfa to 3b05b74 Compare July 31, 2024 08:48
@momocus momocus merged commit f4941b5 into main Sep 16, 2024
5 checks passed
@momocus momocus deleted the pr/issue742/no-tansan branch September 16, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

まだ飲んでない酒がレビューで炭酸なしにな?
2 participants