Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: docker build checksが常に失敗するのを修正 #801

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yonta
Copy link
Collaborator

@yonta yonta commented Dec 13, 2024

build時の引数RUBY_VERSIONを指定していないためエラーになっていた。
build checks時に引数を与えるようにした。

PR #759 とPR #755 の複合でエラーするようになった。

@github-actions github-actions bot requested a review from momocus December 13, 2024 09:16
@yonta yonta removed the request for review from momocus December 13, 2024 09:16
Copy link

github-actions bot commented Dec 13, 2024

📦 esbuild Bundle Analysis for sakazuki

This analysis was generated by esbuild-bundle-analyzer. 🤖
This PR introduced no changes to the esbuild bundle! 🙌

@yonta yonta requested a review from momocus December 13, 2024 09:16
build時の引数RUBY_VERSIONを指定していないためエラーになっていた。
build checks時に引数を与えるようにした。

PR #759 とPR #755 の複合でエラーするようになった。
@yonta yonta force-pushed the pr/docker-check-failed branch from 308a823 to 7a5c93f Compare December 13, 2024 09:29
@yonta
Copy link
Collaborator Author

yonta commented Dec 13, 2024

テストが失敗しているのでこれはこれで直さないと。
たぶんUbuntu latestにimagemagickが入っていない?

  1) Sake Form Photos file_field for photos with one photo makes a sake having one photo
     Failure/Error: photos&.each { |photo| @sake.photos.create(image: photo) }

     MiniMagick::Error:
       You must have ImageMagick or GraphicsMagick installed
     # ./app/controllers/sakes_controller.rb:184:in `block in store_photos'
     # ./app/controllers/sakes_controller.rb:184:in `each'
     # ./app/controllers/sakes_controller.rb:184:in `store_photos'
     # ./app/controllers/sakes_controller.rb:58:in `create'
     # ./spec/system/sake_form_photos_spec.rb:17:in `block (4 levels) in <top (required)>'

でぷりけーてぃど警告も出ているが、Rails7.2のほうで対処済み

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant