Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SRV lookup and use correct ALPN value in TLS #206

Closed
Tracked by #322
tmolitor-stud-tu opened this issue Feb 15, 2019 · 5 comments · Fixed by #385 or #398
Closed
Tracked by #322

Implement SRV lookup and use correct ALPN value in TLS #206

tmolitor-stud-tu opened this issue Feb 15, 2019 · 5 comments · Fixed by #385 or #398
Labels
🎉 Feature Idea or new feature to implement

Comments

@tmolitor-stud-tu
Copy link
Member

Please implement SRV DNS-record lookup (see here: https://wiki.xmpp.org/web/SRV_Records)

This way it is possible to provide an IP/port combination different to the A-record of the xmpp domain.
Even multiple SRV records with different priority are possible and should be tried in order by clients.

This allows server operators to even use port 443 (https) as fallback for environments where only http/https is allowed and all other ports are filtered out.

To multiplex https and xmpp (and possibly others) on port 443 a correct ALPN value of xmpp-client and support of _xmpps-client SRV records is needed.

One service provider (apart from myself) using port 443 multiplexing based on ALPN values and SRV records is conversations.im

@tmolitor-stud-tu
Copy link
Member Author

Additional information: XEP-0368 explains SRV records for direct TLS.

@anurodhp
Copy link
Contributor

Monal has had SRV lookups since 2012.

@tmolitor-stud-tu
Copy link
Member Author

But no support for XEP-0368 and it doesnt set correct ALPN TLS values.

@tmolitor-stud-tu
Copy link
Member Author

this will also allow for faster reconnects and is needed in environments where slow mobile internet access prevents monal from connecting (in time, because of background)...

@Echolon
Copy link
Contributor

Echolon commented Dec 26, 2019

@Echolon Echolon added the 🎉 Feature Idea or new feature to implement label Jan 4, 2020
@Echolon Echolon mentioned this issue Jan 4, 2020
65 tasks
anurodhp pushed a commit that referenced this issue Apr 13, 2020
* Fix #206

This is a bugfix for usage of multiple SRV records and additionally adds
xmpps SRV record and ALPN support

* Make database access concurrent

* Revert "dont block main thread"

This reverts commit 2ffc1a5.

* Fix crash when registering new account via QuickSetup

* Use Apple's new Network Framework
anurodhp pushed a commit that referenced this issue Apr 13, 2020
* Fix utf-8 decoding error DOS vector

* Fix all kinds of state related bugs (carbons etc.)

* fixed logic and builds

* Try to fix multicarbon issue and add more logging

* update active chat with own messages

* Try to fix smacks request bug

* Make outputBuffer dynamic in size

* Fix smacks request bug this time for sure

* Allow jid as roster source

* Fix ambiguous column name

* != nil

* show correct message timestamp

* Basic message draft support (#382)

* Save message drafts

* Using completion handler

* dont block main thread

* stanzaid

* typo

* Implement XEP-0368, fixes #206

This is a bugfix for usage of multiple SRV records and additionally adds
xmpps SRV record and ALPN support

* Make database access concurrent

* Revert "dont block main thread"

This reverts commit 2ffc1a5.

* Fix crash when registering new account via QuickSetup

* remove help

* Create XEPsupport.md

@marmistrz
I create the file in here, so you can start committing and helping out. I will also link that within the read me.

Thank you for you pre-work!

@anurodhp I will merge this directly as a link in the ReadMe. If you disagree on anything just contact me!

* Update ReadMe.md

Added link to XEP list

* Update XEPsupport.md

* Update XEPsupport.md

* Update XEPsupport.md

* Minor XEPSupport.md fix.

* text fix

* super view did load

* v 4.6

* super ugly but allows presence inside presence for now.

* dont crash

* Fix #370 (#388)

* display geo location (#390)

* Revert "text fix"

This reverts commit c30f81f.

Co-authored-by: Anurodh Pokharel <info@monal.im>
Co-authored-by: Friedrich Altheide <11352905+FriedrichAltheide@users.noreply.github.com>
Co-authored-by: Echolon <Echolon@users.noreply.github.com>
Co-authored-by: Marcin Mielniczuk <marmistrz.dev@zoho.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 Feature Idea or new feature to implement
Projects
None yet
3 participants