Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from deprecated qualifiers field to qualifier field and include closure expansion #444

Open
kevinschaper opened this issue Oct 25, 2023 · 3 comments
Assignees

Comments

@kevinschaper
Copy link
Member

While working on adding sssom to solr, I noticed some oddities around whether the qualifiers field was getting an expansion, and I remembered that RENCI folks had noted that qualifiers in our graph is deprecated.

Initially I was going to try to squeeze that update into the other PR, but I found that the biolink model actually needed an update to include qualifier as an Association slot. I made a PR for that, and once it's in, we can update the ingests & schema.

@kevinschaper kevinschaper added this to the 2023-12 Release milestone Oct 25, 2023
@kevinschaper kevinschaper self-assigned this Oct 25, 2023
@kevinschaper
Copy link
Member Author

The biolink model release that we needed for this is out now, but I hate to have the Solr schema change so late in the release process, so I want to push this change to the start of the new release.

@kevinschaper
Copy link
Member Author

While changing the ingests from qualifiers to qualifier I ran into qualifier being a single valued field. Alliance (not sure which taxa, but not all of them) and PomBase g2p both have the potential for using multiple qualifiers on g2p associations.

Since the deprecated field isn't haring us right now, I'm going to move this a couple releases ahead.

@kevinschaper
Copy link
Member Author

Removing milestone, since it's blocked by biolink model

@kevinschaper kevinschaper removed this from the 2024-04 Release milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants