Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace translation_table.yaml with a monarch vocabulary constants file #720

Open
kevinschaper opened this issue Apr 28, 2022 · 1 comment

Comments

@kevinschaper
Copy link
Member

We're only using a very small part of translation_table.yaml, and the yaml lookup doesn't provide the same kind of IDE benefits that we would have from using constants.

We should replace all of the existing global translation table lookups with a monarch vocabulary constants file, and rather than using local translation tables, we can also use separate constants for individual ingests

@monicacecilia
Copy link
Contributor

Dear @kevinschaper -- could I kindly ask you to please check my math and let me know if this is already solved?

@monicacecilia monicacecilia transferred this issue from monarch-initiative/monarch-ingest May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants