This repository was archived by the owner on Feb 11, 2025. It is now read-only.
Show progress if export is already running #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Balance and transaction exports continue to run in the background when the popup is closed or the back button is clicked as long as Mint is still open. However, the download buttons that you see on the main popup screen clear the existing state and start a new export. Now we have two balance exports running simultaneously and the progress bar jumps erratically between the first and second export job progress.
This pull request simply shows the progress screen for those download tasks if a job is already running. Since it is possible for a job to get hung up and never finish the extension will show the error screen after a certain period of inactivity. There is probably a more idiomatic way to accomplish that than a
setTimeout()
, but it works.The "abandoned job" state can be tested easily with the unpacked extension.
chrome://extensions
in a separate tab