fix: icons, interactionsTests, testIds types exports #1369
Conversation
| @@ -103,8 +103,6 @@ const publishedTSComponents = { | |||
| useActiveDescendantListFocus: "hooks/useActiveDescendantListFocus", | |||
| useListenFocusTriggers: "hooks/useListenFocusTriggers", | |||
| useSwitch: "hooks/useSwitch", | |||
| // Don't remove next line | |||
There was a problem hiding this comment.
Pretty sure
We have this marker on the line 87
| "interactionsTests": [ | ||
| "./dist/esm/tests/interactions-utils.d.ts" | ||
| ], | ||
| "testIds": [ | ||
| "./dist/esm/tests/test-ids-utils.d.ts" | ||
| ] |
There was a problem hiding this comment.
Why are these two needed to be publically exposed APIs?
The interactionsTests are mostly wrappers from regular DOM functions and they are very platform specific
There was a problem hiding this comment.
testIds are containing ComponentDefaultTestId which contains all default data-testid for components and it's being used already in the monolith in cypress tests selectors
interactionsTests are exporting functions which helps to build storybook interaction tests and this endpoint is being used in the monday-ui-components rn
Also third one should be storybookComponents to export components we are using to build our storybook, but as they are not converted to ts, they are not here
There was a problem hiding this comment.
ok. I'm not too fond of it as a public API. it creates a coupling between Vibe's internal testing tools with others who consume it, making it harder to refactor. if that's the current state, then fine, but let's try to reduce such dependencies
|
A new prerelease version of this PR has been published: |
https://monday.monday.com/boards/3532714909/pulses/4633056724