feat!: <ThemeProvider> propagate classname to div wrapping children, instead of children directly #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of passing it to children directly
SergeyRoyt
changed the base branch from
master
to
sergeyro/feature/theme-provider-rename-theme-prop
SergeyRoyt
changed the base branch from
sergeyro/feature/theme-provider-rename-theme-prop
to
sergeyro/feature/theme-provider-add-class-name-to-body
SergeyRoyt
changed the base branch from
sergeyro/feature/theme-provider-add-class-name-to-body
to
sergeyro/feature/theme-provider-rename-theme-prop
shlomitc
approved these changes
Jan 7, 2024
… sergeyro/feature/theme-provider-propagate-classname-to-div
SergeyRoyt
commented
Jan 22, 2024
| </>, | ||
| <> | ||
| ThemeProvider is populating theme name <code>className</code> to {"it's child, so don't put "} | ||
| <code>{"<Fragment>"}</code> (<code>{"<>"}</code>) inside - {` it's not accepting `} | ||
| <code>className</code> prop. | ||
| </> |
There was a problem hiding this comment.
maybe replace it with notice about div
SergeyRoyt
commented
Jan 22, 2024
src/components/ThemeProvider/__tests__/themeProvider-tests.jest.js
Outdated
Show resolved
Hide resolved
…propagate-classname-to-div' into sergeyro/feature/theme-provider-propagate-classname-to-div
… sergeyro/feature/theme-provider-propagate-classname-to-div
SergeyRoyt
merged commit bcc384e
into
sergeyro/feature/theme-provider-rename-theme-prop
6 of 9 checks passed
SergeyRoyt
deleted the
sergeyro/feature/theme-provider-propagate-classname-to-div
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/5729775904
Targetting this PR #1869
READY TO MERGE