fix: Button does not dispatch onClick event on edge click

[RitikBora]

Hey @talkor ,

This PR is raised in regards to the issue pointed out in #1766 .

Based on our discussion, there is a very slight diffrence in the onClick and onMouseDown events . Hence, I have fired an onClick event whenever a mouseDownEvent occurs. It takes care of the button edge clicks as well as multiple clicks as everytime a mouseDown event is surely registered

Thanks,
Ritik

[talkor]

@RitikBora I appreciate it, but I didn't mean it's a change we should make in the component but a workaround to avoid the bug where button clicks on the edges do no trigger onClick when the animation is on. We want to allow both onClick and onMouseDown for the consumer of the component to decide which to use according to their needs.

[RitikBora]

Hey @talkor ,

Oh Okay. The change i made wouldn't not hamper the onMouseDown functionality at all. It just fires the onClick event as well.

I'm happy to pullback my request and look into some better solution than a walkaround :) . Let me know if you are ok with that..

Cheers.

[talkor]

Hey @talkor ,

Oh Okay. The change i made wouldn't not hamper the onMouseDown functionality at all. It just fires the onClick event as well.

I'm happy to pullback my request and look into some better solution than a walkaround :) . Let me know if you are ok with that..

Cheers.

Since it's a breaking change (users who called both onClick and onMouseDown will have onClick called twice for example) we wouldn't want to push this change at the moment, especially if it's meant to fix a different minor bug. I suggest to focus on trying to resolve the original bug without affecting the API for now. If you have an idea we'd be more than happy. Thanks!

[RitikBora]

Hey @talkor ,

Understood,

Thanks!!