Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support on className to Checkbox&AttentionBox instead of componentClassName #328

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

hadasfa
Copy link
Contributor

@hadasfa hadasfa commented Nov 9, 2021

Go over this checklist before submitting your Pull Request

Description: Add support on className to Checkbox&AttentionBox instead of componentClassName

Updating existing component

Basic

  • [v] PR has description
  • [] Changes to the component are backward compatible (including selectors structure). If not - add to the title of the PR "BREAKABLE_CHANGE""
  • [v] All changes to the component are reflected in the ReadMe
  • [v] If component is old and was not compliant with the latest guidelines - it was fixed (optional)

Style

Storybook

  • [ v] All the changes to the component should be reflected in the Storybook.
  • [v ] Component passed Accessibility Plugin checks

Tests

  • [ v] All current tests are passing
  • [ v] New functionality is covered with tests
  • [v ] Tests are compliant with TESTING_README.md instructions

@orrgottlieb orrgottlieb merged commit 9cf517e into master Nov 16, 2021
@orrgottlieb orrgottlieb deleted the fix/hadas/component-class-name-prop branch November 16, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants