Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove pointer-events: none, because it causes cursor: not-allow… #40

Conversation

vladmonday
Copy link
Contributor

@vladmonday vladmonday commented Dec 12, 2020

Removing the pointer-events: none for disabled button, because with it the cursor: not-allowed doesn't really work and all disabled button have default cursor instead of the not allowed one.

Updating existing component

Basic

  • PR has description
  • Changes to the component are backward compatible (including selectors structure). If not - add to the title of the PR "BREAKABLE_CHANGE""
  • All changes to the component are reflected in the ReadMe
  • If component is old and was not compliant with the latest guidelines - it was fixed (optional)

Style

Storybook

  • All the changes to the component should be reflected in the Storybook.
  • Component passed Accessibility Plugin checks

Tests

  • All current tests are passing
  • New functionality is covered with tests
  • Tests are compliant with TESTING_README.md instructions

@orrgottlieb
Copy link
Contributor

Hi @vladmonday ,
The reason that we have pointer-events none is - facebook/react#4251
I'm checking to see if it is fixed in 16.13.1 or we might need to upgrade to 17 in order for it to be supported well.
it affects our tooltip when we are wrapping a component with it

@orrgottlieb
Copy link
Contributor

Hi @vladmonday,
https://codepen.io/orrgottl/pen/jOMywxL this is actually how React works (attaching the event to the root element), so this is the reason it doesn't work.
they have several open bugs on the issue.
I rather leave the current issue as it is, We can have a fix for it using native event (which is a much bigger PR)
Let's discuss this
Orr

@shlomitc shlomitc deleted the fix/vlad/remove-pointer-events-none-for-disabled-button branch May 17, 2023 18:01
talkor pushed a commit that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants