Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Coming soon & fix tests errors (css and js) #400

Merged
merged 10 commits into from
Dec 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,126 +1,5 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Accordion renders correctly with accordion items 1`] = `
<div
className="accordion"
>
<div
className="accordion-item"
>
<div
className="expand-collapse--wrapper"
id=""
>
<div
className="expand-collapse"
>
<button
aria-controls="-controls"
aria-expanded={false}
className="expand-collapse__header expand-collapse__section"
onClickCapture={[Function]}
type="button"
>
<svg
aria-hidden={true}
className="icon_component animate-icon-close"
fill="currentColor"
height="24"
onClick={[Function]}
tabIndex="-1"
viewBox="0 0 20 20"
width="24"
>
<path
clipRule="evenodd"
d="M10.5303 12.5303L10 12L9.46967 12.5303C9.76256 12.8232 10.2374 12.8232 10.5303 12.5303ZM10 10.9393L6.53033 7.46967C6.23744 7.17678 5.76256 7.17678 5.46967 7.46967C5.17678 7.76256 5.17678 8.23744 5.46967 8.53033L9.46967 12.5303L10 12L10.5303 12.5303L14.5303 8.53033C14.8232 8.23744 14.8232 7.76256 14.5303 7.46967C14.2374 7.17678 13.7626 7.17678 13.4697 7.46967L10 10.9393Z"
fill="currentColor"
fillRule="evenodd"
/>
</svg>
</button>
</div>
</div>
</div>
<div
className="accordion-item"
>
<div
className="expand-collapse--wrapper"
id=""
>
<div
className="expand-collapse"
>
<button
aria-controls="-controls"
aria-expanded={false}
className="expand-collapse__header expand-collapse__section"
onClickCapture={[Function]}
type="button"
>
<svg
aria-hidden={true}
className="icon_component animate-icon-close"
fill="currentColor"
height="24"
onClick={[Function]}
tabIndex="-1"
viewBox="0 0 20 20"
width="24"
>
<path
clipRule="evenodd"
d="M10.5303 12.5303L10 12L9.46967 12.5303C9.76256 12.8232 10.2374 12.8232 10.5303 12.5303ZM10 10.9393L6.53033 7.46967C6.23744 7.17678 5.76256 7.17678 5.46967 7.46967C5.17678 7.76256 5.17678 8.23744 5.46967 8.53033L9.46967 12.5303L10 12L10.5303 12.5303L14.5303 8.53033C14.8232 8.23744 14.8232 7.76256 14.5303 7.46967C14.2374 7.17678 13.7626 7.17678 13.4697 7.46967L10 10.9393Z"
fill="currentColor"
fillRule="evenodd"
/>
</svg>
</button>
</div>
</div>
</div>
<div
className="accordion-item"
>
<div
className="expand-collapse--wrapper"
id=""
>
<div
className="expand-collapse"
>
<button
aria-controls="-controls"
aria-expanded={false}
className="expand-collapse__header expand-collapse__section"
onClickCapture={[Function]}
type="button"
>
<svg
aria-hidden={true}
className="icon_component animate-icon-close"
fill="currentColor"
height="24"
onClick={[Function]}
tabIndex="-1"
viewBox="0 0 20 20"
width="24"
>
<path
clipRule="evenodd"
d="M10.5303 12.5303L10 12L9.46967 12.5303C9.76256 12.8232 10.2374 12.8232 10.5303 12.5303ZM10 10.9393L6.53033 7.46967C6.23744 7.17678 5.76256 7.17678 5.46967 7.46967C5.17678 7.76256 5.17678 8.23744 5.46967 8.53033L9.46967 12.5303L10 12L10.5303 12.5303L14.5303 8.53033C14.8232 8.23744 14.8232 7.76256 14.5303 7.46967C14.2374 7.17678 13.7626 7.17678 13.4697 7.46967L10 10.9393Z"
fill="currentColor"
fillRule="evenodd"
/>
</svg>
</button>
</div>
</div>
</div>
</div>
`;

exports[`Accordion renders correctly with allowMultiple 1`] = `
<div
className="accordion"
Expand Down
20 changes: 10 additions & 10 deletions src/components/Avatar/__stories__/avatar.stories.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
.monday-style-story-avatar {
&_multiplue {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es lint order errors

display: flex;
align-items: center;
justify-content: center;
padding: 10px 20px 10px 20px;
.monday-style-avatar {
margin: -8px;
}
}

&_multiplue-reverse {
display: flex;
align-items: flex-start;
Expand All @@ -13,14 +23,4 @@
}
}
}

&_multiplue {
display: flex;
align-items: center;
justify-content: center;
padding: 10px 20px 10px 20px;
.monday-style-avatar {
margin: -8px;
}
}
}
6 changes: 0 additions & 6 deletions src/components/Banner/Banner.scss
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,6 @@
border-radius: $border-radius-medium;
object-fit: contain;
}

.banner--close {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate class

align-self: start;
grid-area: close;
border-radius: $border-radius-small;
}
}

&.rtl {
Expand Down
4 changes: 1 addition & 3 deletions src/components/Button/Button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@
@include theme-prop(border-color, ui-border-color);
@include theme-prop(color, primary-text-color);
background-color: transparent;

&.monday-style-button {
&--size {
&-small {
Expand All @@ -192,9 +193,6 @@
line-height: 22px;
}
}
}

&.monday-style-button {
&--color {
&-primary {
&-active,
Expand Down
57 changes: 29 additions & 28 deletions src/components/Checkbox/Checkbox.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ $checkbox-size: 16px;
width: fit-content;
height: min-content;

&__label {
@include font-input();
cursor: pointer;
user-select: none;
margin-inline-start: $spacing-small;
@include theme-prop(color, primary-text-color);
}

&__checkbox {
cursor: pointer;
visibility: visible;
Expand Down Expand Up @@ -64,14 +72,6 @@ $checkbox-size: 16px;
}
}

&__label {
@include font-input();
cursor: pointer;
user-select: none;
margin-inline-start: $spacing-small;
@include theme-prop(color, primary-text-color);
}

// Since it is not possible to change the design of the checkbox according to the requirements using css,
// we hide the checkbox and draw a new one instead.
// In order to allow accessibility, all operations will be performed on the hidden checkbox and be reflected
Expand All @@ -81,13 +81,13 @@ $checkbox-size: 16px;

// For any active attribute in the hidden checkbox, we will change the appearance of the checkbox we drew in its place.
&:focus {
& + .monday-style-checkbox__checkbox {
@include hover-unselected;
}

&:checked + .monday-style-checkbox__checkbox {
@include hover-selected;
}

& + .monday-style-checkbox__checkbox {
@include hover-unselected;
}
}
&:focus-visible {
& + .monday-style-checkbox__checkbox {
Expand All @@ -99,11 +99,21 @@ $checkbox-size: 16px;
}
}

&:checked, &:indeterminate {
&:focus + .monday-style-checkbox__checkbox:after {
@include theme-prop(background-color, primary-hover-color);
&:disabled {
& + .monday-style-checkbox {
&__checkbox,
&__checkbox:hover {
@include theme-prop(background-color, disabled-background-color);
@include theme-prop(border-color, ui-border-color);

.monday-style-checkbox__icon {
@include theme-prop(color, disabled-text-color);
}
}
}
}

&:checked, &:indeterminate {
& + .monday-style-checkbox {
&__checkbox {
animation: checkbox-grow-animation 50ms;
Expand Down Expand Up @@ -137,25 +147,16 @@ $checkbox-size: 16px;
}
}

&:focus + .monday-style-checkbox__checkbox:after {
@include theme-prop(background-color, primary-hover-color);
}

&:disabled + .monday-style-checkbox {
&__checkbox:after {
@include theme-prop(background-color, disabled-background-color);
}
}
}
&:disabled {
& + .monday-style-checkbox {
&__checkbox,
&__checkbox:hover {
@include theme-prop(background-color, disabled-background-color);
@include theme-prop(border-color, ui-border-color);

.monday-style-checkbox__icon {
@include theme-prop(color, disabled-text-color);
}
}
}
}
}
}

Expand Down
10 changes: 5 additions & 5 deletions src/components/Chips/Chips.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ $icon-margin: 4px;
animation: chips-enter 100ms;
animation-timing-function: cubic-bezier(0, 0, 0.35, 1);

.label {
@include font-general-text();
@include ellipsis();
}

&.no-animation {
animation: none;
}
Expand Down Expand Up @@ -52,11 +57,6 @@ $icon-margin: 4px;
@include theme-prop(color, disabled-text-color);
}
}

.label {
@include font-general-text();
@include ellipsis();
}
}

@keyframes chips-enter {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@
display: flex;
border-radius: 4px;

&.selected-color {
.color-item {
border: 2px solid var(--primary-color);
}
}
.color-item {
display: flex;
justify-content: center;
Expand All @@ -24,18 +19,24 @@
width: 24px;
height: 24px;
}

&.color-item-size-medium {
width: 32px;
height: 32px;
}

&.color-item-size-large {
width: 40px;
height: 40px;
}
}

&.selected-color {
.color-item {
border: 2px solid var(--primary-color);
}
}

.color-item-text-mode:hover {
background-color: var(--primary-background-hover-color) !important;
}
Expand Down
1 change: 0 additions & 1 deletion src/components/Dropdown/components/menu/menu.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
0% {
opacity: 0;
z-index: -10000;
transform: translateY(-75px);
transform: translateY(var(--dropdown-menu-fadinY, -75px));
}
100% {
Expand Down
1 change: 0 additions & 1 deletion src/components/ExpandCollapse/ExpandCollapse.scss
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
@keyframes expandContentAnimation {
0% {
opacity: 0;
transform: translateY(-75px);
transform: translateY(var(--dropdown-menu-fadinY, -75px));
}
100% {
Expand Down
1 change: 0 additions & 1 deletion src/components/Icon/CustomSvgIcon.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import React, { useCallback } from "react";
import PropTypes from "prop-types";
import cx from "classnames";
import SVG from "react-inlinesvg";
import "./CustomSvgIcon.scss";
import useIconScreenReaderAccessProps from "../../hooks/useIconScreenReaderAccessProps";

function modifySvgCode(svg, color = "currentColor") {
Expand Down
Empty file.
1 change: 0 additions & 1 deletion src/components/IconButton/IconButton.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import Icon from "../Icon/Icon";
import AddSmall from "../Icon/Icons/components/AddSmall";
import { getWidthHeight } from "./services/IconButton-helpers";
import { SIZES } from "../../constants/sizes";
import "./IconButton.scss";

const IconButton = forwardRef(
({ className, id, icon, size, tooltipContent, ariaLabel, kind, active, disabled, disabledReason, onClick }, ref) => {
Expand Down
Empty file.
Loading