Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support on checkbox click while shift is pressed on firefox browser #514

Merged
merged 9 commits into from
Feb 6, 2022

Conversation

hadasfa
Copy link
Contributor

@hadasfa hadasfa commented Feb 3, 2022

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

Hadas Farhi added 2 commits February 6, 2022 14:12
…to bug/hadas/checkbox-firefox-shift

� Conflicts:
�	package-lock.json
src/components/Checkbox/Checkbox.js Outdated Show resolved Hide resolved
src/utils/user-agent-utils.js Show resolved Hide resolved
@hadasfa hadasfa merged commit 53198d1 into master Feb 6, 2022
@hadasfa hadasfa deleted the bug/hadas/checkbox-firefox-shift branch February 6, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants