Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug on toggle cannot be affected by click when in controlled mode #544

Merged
merged 10 commits into from
Feb 17, 2022
Merged

Fix bug on toggle cannot be affected by click when in controlled mode #544

merged 10 commits into from
Feb 17, 2022

Conversation

hadasfa
Copy link
Contributor

@hadasfa hadasfa commented Feb 17, 2022

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

@hadasfa hadasfa merged commit 0f0ed40 into master Feb 17, 2022
@hadasfa hadasfa deleted the bug/hadas/controlled-toggle branch February 17, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadasfa @orrgottlieb