Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook/sergeyro/expand loader #686

Merged
merged 20 commits into from
Jun 6, 2022
Merged

Conversation

SergeyRoyt
Copy link
Contributor

Loader-component functionality extended:

  • Fixed sizes variants
  • Fixed color variants
  • Fixed visual variants

Storybook updated:

  • Fixed sizes variants
  • Fixed color variants
  • Fixed visual variants
  • Usage tips
  • Do's and don'ts
  • Use cases and examples
  • Related components

Corresponding snapshots are written

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

src/components/Loader/Loader.jsx Outdated Show resolved Hide resolved
src/components/Loader/Loader.jsx Outdated Show resolved Hide resolved
src/components/Loader/Loader.jsx Show resolved Hide resolved
src/components/Loader/Loader.jsx Outdated Show resolved Hide resolved
@SergeyRoyt SergeyRoyt requested a review from hadasfa May 29, 2022 09:05
@SergeyRoyt SergeyRoyt requested a review from hadasfa May 29, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants