🧹 Prevent panic for unsupported operating systems #4009
Conversation
|
I tested this, by removing the linux filter from the sbom policy and run it on my local linux system: |
Test Results2 993 tests 2 992 ✅ 1m 28s ⏱️ Results for commit 9c766e2. ♻️ This comment has been updated with latest results. |
sbom/sbom.go
Outdated
| @@ -72,6 +72,9 @@ func GenerateBom(r *reporter.Report) ([]*Sbom, error) { | |||
|
|
|||
| // extract os packages and python packages | |||
| dataPoints := r.Data[mrn] | |||
| if dataPoints == nil { | |||
| return nil, fmt.Errorf("no data points found") | |||
There was a problem hiding this comment.
If we have no data points, this is not an error in the conversion. We should just return the current constructed bom then without any additional package data.
There was a problem hiding this comment.
When the operating system is not supported, the complete sbom query pack is not executed and we don't have any data:
→ discover related assets for 1 asset(s)
Process 158394 has exited with status 0
Shouldn't we at least show some info?
There was a problem hiding this comment.
Great idea. What we could do is, we set the error state, add a message and at least fill in the asset information. Here is the failed state https://github.com/mondoohq/cnquery/blob/main/sbom/sbom.proto#L38 that we can set here https://github.com/mondoohq/cnquery/blob/main/sbom/sbom.proto#L65. We can set the error message here https://github.com/mondoohq/cnquery/blob/main/sbom/sbom.proto#L81
There was a problem hiding this comment.
I think we want to store the error in the report but not error the report generation.
There was a problem hiding this comment.
This way the CLI still does not show any error, but the json output includes it:
{
"generator": {
"vendor": "Mondoo, Inc.",
"name": "cnquery",
"url": "https://mondoo.com"
},
"timestamp": "2024-05-21T08:31:32Z",
"status": 3,
"asset": {
"name": "X1",
"platform": {}
},
"error_message": "no data points found"
}
Follow-up to #4008 Signed-off-by: Christian Zunker <christian@mondoo.com>
czunker
force-pushed
the
czunker/prevent_sbom_panic
branch
from
c5fbd0c to
9c766e2
Compare
Follow-up to #4008