Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add aws.eks.nodegroup resource (on aws.eks.cluster) #4031

Merged
merged 5 commits into from
May 29, 2024
Merged

Conversation

vjeffrey
Copy link
Contributor

@vjeffrey vjeffrey commented May 19, 2024

Screenshot 2024-05-27 at 20 02 01

@vjeffrey vjeffrey marked this pull request as draft May 19, 2024 20:44

This comment has been minimized.

@tas50
Copy link
Member

tas50 commented May 20, 2024

I have a cluster in 177043759486 you can test against

cnquery> aws.eks.clusters.first
aws.eks.clusters.first: aws.eks.cluster arn="arn:aws:eks:us-west-2:177043759486:cluster/tim_test" version="1.29" status="ACTIVE"
cnquery> aws.eks.clusters.first.nodeGroups
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: 3765ffef-27f5-4c9a-826b-67a70ee548cb, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: 002f323b-be8e-479b-a422-809efc5bba81, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: 272aa5e9-2d30-4e83-885c-21353412c270, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: 7bf26683-b3c9-46b4-989b-496d9a73b786, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: 97a45a9e-85c0-4bcc-b83c-032becea5c5a, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: d6fe97cc-e411-4dda-b953-c0248d5f540f, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: acbee903-5b31-4646-91ad-b008b321d039, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: 54bd8484-049c-49fa-b306-5a2812d6ce57, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: 4b048b2f-d33a-4f72-b99b-dc1b9a4d1682, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: 897e2ba1-3292-4a32-8ff9-10e243e33f6a, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: d2a4ab23-cb31-4862-ae17-b4dd34b6fb20, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: f18be530-a56b-4043-a4d6-37df160c3fc2, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: 4b54592d-7d58-4e67-8706-44ff26207fbb, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: e3bad53d-34e4-4f72-a453-4d2daf3c8278, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: 1220bb1f-bc6a-473f-9c60-5411385facaf, ResourceNotFoundException: No cluster found for name: tim_test.
operation error EKS: ListNodegroups, https response error StatusCode: 404, RequestID: 9f1d4914-7eba-4759-8225-2a4ebe925dd0, ResourceNotFoundException: No cluster found for name: tim_test.
aws.eks.clusters.first.nodeGroups: null

@tas50
Copy link
Member

tas50 commented May 20, 2024

Poking around it looks like it fails because the cost goes through every region looking for that cluster. The 404s cause a failure. I hardcoded the getNodegroups function to just look in us-west-2 where my cluster is and query returns

  nodeGroups: [
    0: aws.eks.nodegroup
  ]

@vjeffrey vjeffrey marked this pull request as ready for review May 28, 2024 02:03
vjeffrey and others added 2 commits May 27, 2024 20:05
Copy link
Contributor

github-actions bot commented May 28, 2024

Test Results

3 031 tests  ±0   3 030 ✅ ±0   1m 25s ⏱️ -15s
  337 suites ±0       1 💤 ±0 
   24 files   ±0       0 ❌ ±0 

Results for commit f1e4d17. ± Comparison against base commit dfdcb94.

♻️ This comment has been updated with latest results.

vjeffrey and others added 2 commits May 27, 2024 20:36
Co-authored-by: Tim Smith <tsmith84@gmail.com>
Signed-off-by: Tim Smith <tsmith84@gmail.com>
@tas50
Copy link
Member

tas50 commented May 28, 2024

LGTM from the product side

@imilchev imilchev merged commit 1966fe4 into main May 29, 2024
16 checks passed
@imilchev imilchev deleted the vj/eksnodegroup branch May 29, 2024 16:25
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants