-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add aws.eks.nodegroup resource (on aws.eks.cluster) #4031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vjeffrey
commented
May 19, 2024
•
edited
Loading
edited
This comment has been minimized.
This comment has been minimized.
tas50
reviewed
May 20, 2024
tas50
reviewed
May 20, 2024
tas50
reviewed
May 20, 2024
tas50
reviewed
May 20, 2024
I have a cluster in 177043759486 you can test against
|
Poking around it looks like it fails because the cost goes through every region looking for that cluster. The 404s cause a failure. I hardcoded the
|
tas50
reviewed
May 20, 2024
tas50
reviewed
May 20, 2024
tas50
reviewed
May 20, 2024
Co-authored-by: Tim Smith <tsmith84@gmail.com>
Co-authored-by: Tim Smith <tsmith84@gmail.com>
Signed-off-by: Tim Smith <tsmith84@gmail.com>
LGTM from the product side |
imilchev
approved these changes
May 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.