Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Assume connection reset means the server rejects all ciphersuites #4038

Merged
merged 1 commit into from
May 23, 2024

Conversation

jaym
Copy link
Contributor

@jaym jaym commented May 21, 2024

When testing for supported ciphersuites, some servers fail the check with:

read: connection reset by peer

This seems to consistently happen on these servers. And it seems to happen on requests where the only ciphersuites in the ClientHello are unsupported ones

When testing for supported ciphersuites, some servers fail the check
with:
```
read: connection reset by peer
```

This seems to consistently happen on these servers. And it seems to
happen on requests where the only ciphersuites in the `ClientHello` are
unsupported ones
Copy link
Contributor

Test Results

2 996 tests  ±0   2 995 ✅ ±0   1m 27s ⏱️ +6s
  329 suites ±0       1 💤 ±0 
   23 files   ±0       0 ❌ ±0 

Results for commit d403eb6. ± Comparison against base commit 8453617.

Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @jaym

@jaym jaym merged commit fcb6e6e into main May 23, 2024
15 checks passed
@jaym jaym deleted the jdm/tls-reset branch May 23, 2024 18:37
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants