Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Make path an arg, not a flag for the FS conn. #4108

Merged
merged 1 commit into from
May 27, 2024

Conversation

preslavgerchev
Copy link
Contributor

@preslavgerchev preslavgerchev commented May 27, 2024

Aligns the provider with #4105 by having the path as an arg. Passing it in as a flag is still supported, but deprecated

Signed-off-by: Preslav <preslav@mondoo.com>
Copy link
Contributor

Test Results

3 002 tests  ±0   3 001 ✅ ±0   1m 29s ⏱️ ±0s
  331 suites ±0       1 💤 ±0 
   23 files   ±0       0 ❌ ±0 

Results for commit e79b198. ± Comparison against base commit b0ae89e.

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @preslavgerchev

@chris-rock chris-rock merged commit be98dcb into main May 27, 2024
15 checks passed
@chris-rock chris-rock deleted the preslav/fs-path-arg branch May 27, 2024 16:47
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants