Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add []aws.ec2.networkinterface to aws.ec2.instance #4113

Merged
merged 6 commits into from
May 29, 2024

Conversation

vjeffrey
Copy link
Contributor

Screenshot 2024-05-27 at 23 05 10

This comment has been minimized.

Copy link
Contributor

Test Results

3 000 tests  ±0   2 999 ✅ ±0   1m 25s ⏱️ -1s
  331 suites ±0       1 💤 ±0 
   23 files   ±0       0 ❌ ±0 

Results for commit 0119992. ± Comparison against base commit 981a931.

vjeffrey and others added 4 commits May 28, 2024 09:52
Co-authored-by: Tim Smith <tsmith84@gmail.com>
Signed-off-by: Tim Smith <tsmith84@gmail.com>
Signed-off-by: Tim Smith <tsmith84@gmail.com>
Signed-off-by: Tim Smith <tsmith84@gmail.com>
@tas50
Copy link
Member

tas50 commented May 28, 2024

LGTM from the product side

Copy link
Contributor

@misterpantz misterpantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice docs! No suggestions. :)

Copy link
Member

@imilchev imilchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everyone seems to agree this is good to go!

@imilchev imilchev merged commit 69db038 into main May 29, 2024
8 checks passed
@imilchev imilchev deleted the vj/ec2-netwinterf branch May 29, 2024 08:16
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants