🧹 Split device discovery from partition discovery in blockdevices.go #4115
Conversation
preslavgerchev
force-pushed
the
preslav/parts-fix
branch
from
eaa5cd9 to
c2c7e5b
Compare
| return nil, err | ||
| } | ||
| var device snapshot.BlockDevice | ||
| var deviceErr error | ||
| // if we have exactly one device present at the LUN we can directly point the volume mounter towards it |
There was a problem hiding this comment.
this needs to be update? we, on top, look for the block device.
There was a problem hiding this comment.
it says that we have exactly one device that is found through the LUN lookup, which is what the if check does
There was a problem hiding this comment.
This is absolutely a nitpick, my point here was that, we added an extra step here, we are no longer just passing the volume path directly, we now try to find the block.
That's all.
There was a problem hiding this comment.
ah, i see your point, ive adjusted it
| @@ -57,7 +57,7 @@ func filterScsiDevices(scsiDevices scsiDevices, lun int) []scsiDeviceInfo { | |||
| // there can be multiple devices mounted at the same LUN. | |||
| // the LUN so we need to find all the blocks, mounted at that LUN. then we find the first one | |||
| // that has no mounted partitions and use that as the target device. this is a best-effort approach | |||
There was a problem hiding this comment.
could we please update this comment?
There was a problem hiding this comment.
what would you like to have updated? it still is relevant to the code it refers to
| sortPartitionsBySize(partitions) | ||
|
|
||
| // return the largest partition. we can extend this to be a parameter in the future | ||
| devFsName := "/dev/" + partitions[0].Name |
There was a problem hiding this comment.
If we only sort the partitions to return the largest one, if feels a waste of processing.
I know that we won't have a huge number of partitions so, processing here is low-cost, but if feels that the sorting is unnecessary.
There was a problem hiding this comment.
i can also replace this with iterating over and keeping track of the one with the largest size. this just felt like less code
preslavgerchev
force-pushed
the
preslav/parts-fix
branch
from
370b91f to
4ba969f
Compare
Signed-off-by: Preslav <preslav@mondoo.com>
preslavgerchev
force-pushed
the
preslav/parts-fix
branch
from
d59d704 to
e3c7f44
Compare
Split device discovery from partition discovery entirely. This means that the code is now more predictable and makes less assumptions.