🐛 Fix find files panic for FS connections. #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preslavgerchev
force-pushed
the
preslav/fix-panic
branch
from
ca8cce7 to
2f43f42
Compare
imilchev
approved these changes
Jun 18, 2024
Signed-off-by: Preslav <preslav@mondoo.com>
preslavgerchev
force-pushed
the
preslav/fix-panic
branch
from
2f43f42 to
84e41a9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If files do not exist, we return
nilfrom thehandleFsErrorwhich means theWalkDirdoesn't skip over that specific file. This lead to panics when runningfiles.findquery against an FS connection, e.g.files.find(from: "/etc/audit/rules.d",regex:'.*\.rules$' , type: "file")