✨Run status check on login errors #4325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you fix the linter issue? |
|
@imilchev done |
imilchev
reviewed
Jul 9, 2024
apps/cnquery/cmd/login.go
Outdated
| err := register(token, annotations, timer, splay) | ||
| if err != nil { | ||
| defer func() { | ||
| err := StatusCmd.RunE(cmd, args) |
There was a problem hiding this comment.
it's a bit weird to run 1 command from another. Can you extract whatever is in the status command into a separate function and just call that function here and in StatusCmd.Run. I don't think you need the args at all for checking the status
…ommand in login command
imilchev
reviewed
Jul 10, 2024
apps/cnquery/cmd/status.go
Outdated
| // try to load config into credentials struct | ||
| credentials := opts.GetServiceCredential() | ||
| if credentials != nil && len(credentials.Mrn) > 0 { | ||
| s.Client.ParentMrn = credentials.ScopeMrn |
There was a problem hiding this comment.
I am not sure if this breaks anything. What if I have an old service account that still has ParentMrn instead of ScopeMrn. My integration will be broken in that case and I would need to re-create my service account. I suggest not changing this now because we don't know what the impact will be for customers
imilchev
approved these changes
Jul 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves mondoohq/cnspec#1342