Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confluence shared connection type #4414

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Fix confluence shared connection type #4414

merged 2 commits into from
Jul 29, 2024

Conversation

tas50
Copy link
Member

@tas50 tas50 commented Jul 26, 2024

I'm assuming this is a typo.

@tas50
Fix confluence shared connection type
d450fda 
I'm assuming this is a typo.

Signed-off-by: Tim Smith <tsmith84@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 26, 2024 •
edited
Loading

Test Results

3 079 tests  ±0   3 078 ✅ ±0   1m 29s ⏱️ ±0s
  363 suites ±0       1 💤 ±0 
   27 files   ±0       0 ❌ ±0 

Results for commit f943657. ± Comparison against base commit 4493ea5.

♻️ This comment has been updated with latest results.

@preslavgerchev
Copy link
Contributor

nice catch @tas50, i updated the rest of the provider code to ensure we reference this variable everywhere

@preslavgerchev preslavgerchev merged commit c3e9115 into main Jul 29, 2024
15 checks passed
@preslavgerchev preslavgerchev deleted the tas50/confluence branch July 29, 2024 05:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@preslavgerchev preslavgerchev preslavgerchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tas50 @preslavgerchev