Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Add tech url segments for google workspace. Improve asset name #4432

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

preslavgerchev
Copy link
Contributor

@preslavgerchev preslavgerchev commented Jul 29, 2024

  • Add tech url segments for google workspace
  • Asset name now is the primary domain + the customer id. E.g. Google Workspace mondoo.com B1g0kA3gQ
  • Improve error message when the creds, specified in --credentials-path do not exist.

Fixes #4403

@preslavgerchev preslavgerchev force-pushed the preslav/g-workspace-improvs branch from 5f75cda to 8047183 Compare July 29, 2024 13:15
Copy link
Contributor

github-actions bot commented Jul 29, 2024

Test Results

3 080 tests  ±0   3 079 ✅ ±0   1m 24s ⏱️ -9s
  363 suites ±0       1 💤 ±0 
   27 files   ±0       0 ❌ ±0 

Results for commit cf1ad5e. ± Comparison against base commit 7ae5a9d.

♻️ This comment has been updated with latest results.

@tas50
Copy link
Member

tas50 commented Jul 29, 2024

@preslavgerchev Where in the chart will google workspace be landing with this tech segment URL work?

@chris-rock
Copy link
Member

@tas50 Can you provide the way you would like to have the grouping? At this point it just groups everything under Google Workspace

@tas50
Copy link
Member

tas50 commented Jul 29, 2024

@preslavgerchev and I chatted about this. I'm going to get sign off on the proposed hierarchy before we merge this. I'll have that today.

@tas50 tas50 changed the title 🧹 Add tech url segments for google workspace. Improve asset name. 🧹 Add tech url segments for google workspace. Improve asset name Jul 29, 2024
@tas50
Copy link
Member

tas50 commented Jul 30, 2024

@preslavgerchev Please update this to be SaaS -> Google Workspace as the categories

Signed-off-by: Preslav <preslav@mondoo.com>
Signed-off-by: Preslav <preslav@mondoo.com>
@preslavgerchev
Copy link
Contributor Author

this is rfr again, the url is now saas -> google workspace (category) -> customer id

@preslavgerchev preslavgerchev force-pushed the preslav/g-workspace-improvs branch from 016be7a to cf1ad5e Compare July 30, 2024 15:36
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @preslavgerchev

@preslavgerchev preslavgerchev merged commit cd27b50 into main Jul 30, 2024
15 checks passed
@preslavgerchev preslavgerchev deleted the preslav/g-workspace-improvs branch July 30, 2024 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add assetname and technology url for google workspace
3 participants