Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐ Adding support to get the MongoDB and PostgreSQL cosmodb Types (Azure) #4435

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

HRouhani
Copy link
Contributor

@HRouhani HRouhani commented Jul 29, 2024

Screenshot from 2024-07-29 18-49-59

Based on the current capabilities of the Azure SDK for Go, it appears that the kind, tags, and specially properties attributes are not directly available for Cosmodb type MongoDB and PostgreSQL server groups through the SDK.

@HRouhani HRouhani force-pushed the hossein/azure-cosmodb-types branch from 9ef529d to dcdfe9d Compare July 29, 2024 16:48
@tas50 tas50 changed the title 🧹 Adding support to get the MongoDB and PostgreSQL cosmodb Types (Azure) ⭐ Adding support to get the MongoDB and PostgreSQL cosmodb Types (Azure) Jul 29, 2024
Copy link
Contributor

github-actions bot commented Jul 29, 2024

Test Results

3 080 tests  ±0   3 079 ✅ ±0   1m 27s ⏱️ -3s
  363 suites ±0       1 💤 ±0 
   27 files   ±0       0 ❌ ±0 

Results for commit 53ce8b2. ± Comparison against base commit df9f6d7.

♻️ This comment has been updated with latest results.

@HRouhani HRouhani requested a review from preslavgerchev July 29, 2024 16:51
@HRouhani HRouhani force-pushed the hossein/azure-cosmodb-types branch from dcdfe9d to 8e86b33 Compare July 30, 2024 07:27
HRouhani added 3 commits July 30, 2024 13:58
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
@HRouhani HRouhani force-pushed the hossein/azure-cosmodb-types branch from 8e86b33 to 53ce8b2 Compare July 30, 2024 12:03
@preslavgerchev
Copy link
Contributor

@HRouhani, have you tested if we get back other postgresql and mongodb instances when running this from the cosmosdb resource? What if I create a flexible postgresql server, will that end up in the results when querying cosmodb accounts?

@HRouhani
Copy link
Contributor Author

@HRouhani, have you tested if we get back other postgresql and mongodb instances when running this from the cosmosdb resource? What if I create a flexible postgresql server, will that end up in the results when querying cosmodb accounts?

Very good question. No it is not possible:

the PostgreSQL has different resource type which is : Microsoft.DBforPostgreSQL/flexibleServers

and MondoDB Atlas has different API, need to get it from Market place first.

@preslavgerchev preslavgerchev merged commit 3bf3e9f into main Jul 31, 2024
15 checks passed
@preslavgerchev preslavgerchev deleted the hossein/azure-cosmodb-types branch July 31, 2024 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants