GitHub repo discovery performance #4449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we did some optimizations to fetch repositories only once. While this makes sense when we do discovery there are cases where fetching all repos from an org or user does not make sense. A specific case is when I just want to scan a single repo.
That call should not fetch all repos of an org. It makes scanning an org for large organizations slower. This PR fixes it. It changes the code to leverage a cache. If that cache exists (eg. because a user called
github.organization.repositories
) then its used.before
after