Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 allow cross-provider containers from k8s #4484

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

imilchev
Copy link
Member

@imilchev imilchev commented Aug 5, 2024

This is not a proper fix but a workaround to make sure the specific command works. We will need to re-visit cross-provider resources at some point.

Fixes #4472

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Test Results

3 097 tests  ±0   3 096 ✅ ±0   1m 26s ⏱️ -12s
  370 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 8b13efa. ± Comparison against base commit fd2a7d3.

Copy link
Member

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's keep this as a temporary workaround until we streamline cross-provider calling

@arlimus arlimus merged commit ae90ce7 into main Aug 5, 2024
15 checks passed
@arlimus arlimus deleted the ivan/k8s-containers branch August 5, 2024 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s.deployments ERROR: rpc error: code = Unknown desc = cannot find connection type k8s
2 participants