✨ Improve ec2 discovery: do not fetch instances twice, use tags to filter #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
preslavgerchev
commented
Sep 18, 2024
•
preslavgerchev
commented
- use passed in tags as filters
- use passed in instance ids as filters
…lter out instances during DescribeInstances. Signed-off-by: Preslav <preslav@mondoo.com>
preslavgerchev
commented
Sep 18, 2024
providers/aws/resources/aws_ec2.go
Outdated
| @@ -911,7 +872,7 @@ func (a *mqlAwsEc2) gatherInstanceInfo(instances []ec2types.Reservation, imdsvVe | |||
| "ebsOptimized": llx.BoolDataPtr(instance.EbsOptimized), | |||
| "enaSupported": llx.BoolDataPtr(instance.EnaSupport), | |||
| "httpEndpoint": llx.StringData(string(instance.MetadataOptions.HttpEndpoint)), | |||
| "httpTokens": llx.StringData(httpTokens), | |||
| "httpTokens": llx.StringData(string(instance.MetadataOptions.HttpTokens)), | |||
There was a problem hiding this comment.
this is why we were doing it twice, it's now returned as a response
Signed-off-by: Preslav <preslav@mondoo.com>
Signed-off-by: Preslav <preslav@mondoo.com>
vjeffrey
reviewed
Sep 19, 2024
vjeffrey
approved these changes
Sep 19, 2024
Signed-off-by: Preslav <preslav@mondoo.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.