Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 properly handle windows powershell errors #4749

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

imilchev
Copy link
Member

Make sure we properly surface errors from powershell execution

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
Copy link
Contributor

Test Results

3 116 tests  ±0   3 115 ✅ ±0   1m 34s ⏱️ +8s
  371 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit f5e3a40. ± Comparison against base commit 6418cdc.

Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @imilchev

@czunker czunker merged commit a6298a9 into main Oct 15, 2024
15 checks passed
@czunker czunker deleted the ivan/windows-error-handling branch October 15, 2024 10:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants