🐛 allow running shodan provider with inventory file #4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Milchev <ivan@mondoo.com>
imilchev
commented
Oct 17, 2024
| @@ -51,10 +52,9 @@ func (s *Service) ParseCLI(req *plugin.ParseCLIReq) (*plugin.ParseCLIRes, error) | |||
| if token == "" { | |||
| token = os.Getenv("SHODAN_TOKEN") | |||
| } | |||
| if token == "" { | |||
| return nil, errors.New("no shodan token provided, use --token or SHODAN_TOKEN") | |||
There was a problem hiding this comment.
This is also validated in the connection. We don't need to check it here. This makes sure inventory files with vault secrets are accepted. If no token is provided, we will error out when the connection is created
cnquery/providers/shodan/connection/connection.go
Lines 53 to 55 in ffa7135
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an inventory file which provides the Shodan token as a vault secret triggeres an error. This is now fixed and we can run scans with vault secrets for Shodan