Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 fixing a bug in NamedLocation under conditional access - MS365 #4845

Merged
merged 1 commit into from
Nov 13, 2024
Merged

🧹 fixing a bug in NamedLocation under conditional access - MS365 #4845

merged 1 commit into from
Nov 13, 2024

Conversation

HRouhani
Copy link
Contributor

Screenshot from 2024-11-12 18-10-29

returns unique values

@HRouhani
🧹 fixing a bug in NamedLocation under confitional access - MS365
425be68 
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
@github-actions GitHub Actions
Copy link
Contributor

Test Results

3 145 tests  ±0   3 144 ✅ ±0   1m 23s ⏱️ -6s
  371 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 425be68. ± Comparison against base commit 001ee01.

@HRouhani HRouhani changed the title 🧹 fixing a bug in NamedLocation under confitional access - MS365 🧹 fixing a bug in NamedLocation under conditional access - MS365 Nov 12, 2024
@HRouhani HRouhani added the ms365 label Nov 12, 2024
@HRouhani
Copy link
Contributor Author

@czunker It is also related to the previous PR!

czunker
czunker approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Do you now need the same also for the countryNamedLocation?

@HRouhani
Copy link
Contributor Author

LGTM Do you now need the same also for the countryNamedLocation?

Thanks, the other one has already!

@HRouhani HRouhani merged commit a4e4356 into main Nov 13, 2024
15 checks passed
@HRouhani HRouhani deleted the hossein/ms365-fix-namedLocation branch November 13, 2024 14:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@czunker czunker czunker approved these changes

Assignees
No one assigned
Labels
ms365
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HRouhani @czunker