⭐ restore scan -o report #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: After the migration we are loosing some context from policy bundles, so we don't always have the asset policy available in the bundle. There is a new shared call in the resolved policy, which can help find the top policies given any bundle. This also means that we can hand it any random bundle we are about and given a resolved policy find the root policies that were pulled from the bundle. It helps render policies in order i.e. embedded policies are can be tackled further down. We only need this approach when looking at policies in their hierarchy, as for everything else we can just take the bundle and the results. Since the report displays policies in their hierarchy, it required these new calls. Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
chris-rock
approved these changes
Oct 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: After the migration we are loosing some context from policy bundles, so we don't always have the asset policy available in the bundle. There is a new shared call in the resolved policy, which can help find the top policies given any bundle. This also means that we can hand it any random bundle we are about and given a resolved policy find the root policies that were pulled from the bundle. It helps render policies in order i.e. embedded policies are can be tackled further down. We only need this approach when looking at policies in their hierarchy, as for everything else we can just take the bundle and the results. Since the report displays policies in their hierarchy, it required these new calls.
Signed-off-by: Dominik Richter dominik.richter@gmail.com