🐛 simplify default mql bundle fetching #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
chris-rock/default-bundle
branch
from
45106df to
befeab5
Compare
arlimus
approved these changes
Oct 8, 2022
There was a problem hiding this comment.
Glad to see the introduction of the hub API.
For context: We had long discussions about whether to hard-code this or offer via API. In the end, we decided for an API to be more flexible with what the default policies will look like. It still retrieves URLs, which allow us to move things around quickly if needed. Also this approach will move away from Github URLs since they are too limited these days without an API key
Thank you Chris!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.