Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ mqueries.RefreshChecksums + migrate tests #59

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

arlimus
Copy link
Member

@arlimus arlimus commented Oct 10, 2022

Also exposes a few more methods we want to share on the interface.

Signed-off-by: Dominik Richter dominik.richter@gmail.com

Also exposes a few more methods we want to share on the interface.

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>

func TestMquery_Whitespaces(t *testing.T) {
mq := Mquery{
Query: " mondoo { version \n} \t\n ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arlimus should this be mondoo or cnspec?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% that we need to migrate the mondoo resource. I think the better name is mql since the resource is available in cnquery and cnspec.

Since this PR just adds tests, I propose we do this change in a followup PR

Copy link
Contributor

@scottford-io scottford-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arlimus there are some references to mondoo that I think should be cnspec

}

mqexpect := Mquery{
Query: "mondoo { version \n}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this...mondoo or cnspec?


func TestMquery_CodeIDs(t *testing.T) {
mqAssetFilter := Mquery{
Query: "mondoo { version \n}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this...mondoo or cnspec?

}

mqReg := Mquery{
Query: "mondoo { version \n}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this...mondoo or cnspec?


func TestMquery_Whitespaces(t *testing.T) {
mq := Mquery{
Query: " mondoo { version \n} \t\n ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% that we need to migrate the mondoo resource. I think the better name is mql since the resource is available in cnquery and cnspec.

Since this PR just adds tests, I propose we do this change in a followup PR

@chris-rock chris-rock merged commit cf0c691 into main Oct 10, 2022
@chris-rock chris-rock deleted the dom/checksums branch October 10, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants