🛑 remove all v1 code deprecations for v7 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlimus
force-pushed
the
dom/v7
branch
4 times, most recently
from
445ab01 to
c89091a
Compare
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
jaym
reviewed
Oct 14, 2022
| @@ -154,28 +152,20 @@ func (em *executionManager) executeCodeBundle(codeBundle *llx.CodeBundle, props | |||
|
|
|||
| var executor iExecutor | |||
There was a problem hiding this comment.
[nit] iExecutor is not needed. there is only one implementation now
jaym
approved these changes
Oct 14, 2022
|
I have read the Mondoo CLA Document and I hereby sign the CLA |
|
recheck |
requires cnquery to merge mondoohq/cnquery#264 + go.mod to be updated, otherwise this doesnt work Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires cnquery to merge mondoohq/cnquery#264 + go.mod to be updated, otherwise this doesnt work