fix: exclude services from assets score check in the integration test

mondoohq · Jun 20, 2024 · 1340f0e · 1340f0e
1 parent 0ff41c3
commit 1340f0e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/tests/integration/audit_config_base_suite.go b/tests/integration/audit_config_base_suite.go
@@ -223,7 +223,15 @@ func (s *AuditConfigBaseSuite) testMondooAuditConfigKubernetesResources(auditCon
 	assetsExceptCluster := utils.ExcludeClusterAsset(assets)
 
 	// TODO: this number should exclude services and the cluster asset
-	s.Equalf(len(assets)-4, len(assetsExceptCluster), "Cluster asset was sent upstream.")
+	srvs := &corev1.ServiceList{}
+	err = s.testCluster.K8sHelper.ExecuteWithRetries(func() (bool, error) {
+		if err := s.testCluster.K8sHelper.Clientset.List(s.ctx, srvs); err != nil {
+			return false, nil
+		}
+		return true, nil
+	})
+	s.NoError(err, "Failed to list Kubernetes Services")
+	s.Equalf(len(assets)-1-len(srvs.Items), len(assetsExceptCluster), "Cluster asset was sent upstream.")
 
 	assetNames := utils.AssetNames(assetsExceptCluster)
 	s.ElementsMatchf(workloadNames, assetNames, "Workloads were not sent upstream.")

diff --git a/tests/integration/audit_config_namespace_test.go b/tests/integration/audit_config_namespace_test.go
@@ -80,7 +80,7 @@ func (s *AuditConfigCustomNamespaceSuite) TearDownSuite() {
 	s.AuditConfigBaseSuite.TearDownSuite()
 }
 
-func (s *AuditConfigCustomNamespaceSuite) TestReconcile_KubernetesResources2() {
+func (s *AuditConfigCustomNamespaceSuite) TestReconcile_KubernetesResources() {
 	auditConfig := utils.DefaultAuditConfigMinimal(s.ns.Name, true, false, false, false)
 	auditConfig.Spec.Scanner.ServiceAccountName = s.sa.Name
 	s.testMondooAuditConfigKubernetesResources(auditConfig)