Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix private image container scans #1070

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

imilchev
Copy link
Member

makes sure private container image scans work. The issue was that the container pull secrets were overriding the mondoo folder, so the mondoo config was no longer available. That resulted in failure to communicate with upstream

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
czunker
czunker previously approved these changes Mar 26, 2024
Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @imilchev

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
Copy link

Test Results

  9 files  ±  0   54 suites  +45   4h 47m 43s ⏱️ - 2h 33m 45s
293 tests +273  293 ✅ +280  0 💤 ±0  0 ❌  -  7 
433 runs  +253  433 ✅ +308  0 💤 ±0  0 ❌  - 55 

Results for commit c3e1298. ± Comparison against base commit 15b620d.

@imilchev imilchev merged commit 220eb5a into main Mar 26, 2024
24 checks passed
@imilchev imilchev deleted the ivan/fix-private-container-scans branch March 26, 2024 13:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants