✨ Detect OOMkilled status for the operator itself #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hit kubernetes-sigs/controller-runtime#2362 in the tests, but the issue provides a workaround. |
czunker
changed the title
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Try to detect OOMkilled status for the operator before it gets killed again. Report the status upstream and add it the MondooAuditConfig status. Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
czunker
force-pushed
the
christian/detect_operator_oom
branch
from
d0f6429 to
49890ca
Compare
czunker
commented
Nov 16, 2023
| @@ -70,7 +70,6 @@ func (mr *MetricsReconciler) Start(ctx context.Context) error { | |||
| } | |||
|
|
|||
| func (mr *MetricsReconciler) metricsLoop() { | |||
| mr.log.Info("Updating metrics") | |||
There was a problem hiding this comment.
This one was filling up the logs. We don't have a debug level, so I removed it.
Signed-off-by: Christian Zunker <christian@mondoo.com>
czunker
force-pushed
the
christian/detect_operator_oom
branch
from
4c78466 to
07ac777
Compare
imilchev
reviewed
Nov 17, 2023
Signed-off-by: Christian Zunker <christian@mondoo.com>
czunker
force-pushed
the
christian/detect_operator_oom
branch
from
07ac777 to
c19a205
Compare
Good call. The tests revealed some cases where the code wouldn't have updated the status correctly. |
czunker
force-pushed
the
christian/detect_operator_oom
branch
2 times, most recently
from
4a26977 to
d5268ec
Compare
Signed-off-by: Christian Zunker <christian@mondoo.com>
czunker
force-pushed
the
christian/detect_operator_oom
branch
from
d5268ec to
7ad6a23
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Status Condition for the controller itself: