You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
&anonimal EinMByte: Hmm. Ok, so ideally all current filesystem code in app should be in core and we just need a way to interface to it through app?
* anonimal should actually pull up the code
&anonimal lol, I think I answered my own question.
&anonimal So, since app is the 'the third wheel', e.g., the throw-away piece that's only needed to run as stand-alone, EinMByte we could just abstract the calls to *something* in core, and from there within core point to the real filesystem implementation.
&anonimal EinMByte: ^ sound about right?
+EinMByte maybe, but make sure that core know nothing about app
+EinMByte (in think that was the main reason for how it's currently done)
&anonimal Yeah, exactly.
&anonimal But the problem with what we have now is that its redundant code that is confusing to maintain.
The text was updated successfully, but these errors were encountered:
Our data path / data dir is hardcoded, defined at compile time. There is
nothing flexible about it: once you start the router, you it will work
within the same data directory indefinitely (though there are some
run-time options that provide *some* flexibility where some of the
data within the directory can be found/redirected).
Initializing router context (as if the data dir were a mutable type)
is unnecessary and confusing. Ideally, we would *like* as much
flexibility as possible but, for now; this lends itself to breakage.
Also, this commit moves any filesystem related confusion out of app and
into core because of said reasons (and to remove redundancy). This is
not the *ideal* abstraction I had in mind for monero-project#330 but it is good
enough for now (and solves the issue at hand).
Run-time breakage was introduced in 95b35bf because of said reasons.
Closesmonero-project#330
- Replaces rotation by size with rotation by time
- Replaces log filename count template with date template
- Add commented code for a potential file collector (requires boost 1.61+)
- Remove un-related TODO's in the area that were resolved in monero-project#330
References monero-project#375
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
By submitting this issue, I confirm the following:
Place an X inside the bracket to confirm
Discussed after #329, referencing #98:
The text was updated successfully, but these errors were encountered: