Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update android docker build #1571

Closed

Conversation

@MoroccanMalinois MoroccanMalinois mentioned this pull request Sep 24, 2018
@dEBRUYNE-1
Copy link
Contributor

I presume this particular PR is not necessary for GUI v0.13.0.0 right?

@MoroccanMalinois
Copy link
Contributor Author

exact

@zpaxyrco
Copy link

compiling latest changes for android32 i have

/opt/android/toolchain-arm/lib/gcc/aarch64-linux-android/4.9.x/../../../../include/c++/4.9.x/__tree:1819:22: error: the specified comparator type does not provide a const call operator [-Werror,-Wuser-defined-warnings]
__trigger_diagnostics()), "");
^
/opt/android/toolchain-arm/lib/gcc/aarch64-linux-android/4.9.x/../../../../include/c++/4.9.x/__tree:960:70: note: in instantiation of member function 'std::__ndk1::__tree<std::__ndk1::pair<std::__ndk1::pair<double, long>, crypto::hash>, cryptonote::txCompare, std::__ndk1::allocator<std::__ndk1::pair<std::__ndk1::pair<double, long>, crypto::hash> > >::~__tree' requested here
template <class, class, class> friend class _LIBCPP_TEMPLATE_VIS set;
^
/opt/android/toolchain-arm/lib/gcc/aarch64-linux-android/4.9.x/../../../../include/c++/4.9.x/__tree:970:7: note: from 'diagnose_if' attribute on '__trigger_diagnostics':
�[0m�[91m _LIBCPP_DIAGNOSE_WARNING(!__invokable<_Compare const&, _Tp const&, _Tp const&>::value,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/android/toolchain-arm/lib/gcc/aarch64-linux-android/4.9.x/../../../../include/c++/4.9.x/__config:1095:20: note: expanded from macro '_LIBCPP_DIAGNOSE_WARNING'
attribute((diagnose_if(VA_ARGS, "warning")))

on CMakeLists.txt there is

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error=user-defined-warnings")

smth else is that zlib wont compile for arm64

any help?

all output

https://pastebin.com/vyVKvEqA

@MoroccanMalinois
Copy link
Contributor Author

Are you sure you have

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error=user-defined-warnings")

in monero-gui/monero/CMakeLists.txt, not monero/CMakeLists.txt ?

@zpaxyrco
Copy link

zpaxyrco commented Sep 30, 2018

u are right on cmd works

confused from complexity....

what about zlib on arm64

i checked and until now solution

@twiuglufosfa
Copy link

any help for #1641

almost one month and ur changes are not inserted

is like some core devs are against monero expansion

@selsta
Copy link
Collaborator

selsta commented Nov 29, 2018

ping @MoroccanMalinois can you rebase this? also is this up to date?

@Edan3blov
Copy link

three months and your changes are not inserted.

why all this?
can u write here what is need to be done for having a almost working android

till now only cmd on termux.

@selsta
Copy link
Collaborator

selsta commented Jun 21, 2019

Thanks for the PR, let’s continue in #1925

+resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants