macOS: add basic menubar support #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
selsta
commented
Jul 1, 2019
•
selsta
commented
selsta
changed the title
sanderfoobar
approved these changes
Jul 15, 2019
|
@selsta Needs a rebase. |
|
Rebased, but there’s still a bug that breaks Windows and Linux compilation :/ |
selsta
force-pushed
the
menubar3
branch
2 times, most recently
from
2992353
to
26e63ed
Compare
selsta
changed the title
|
Due to a bug in Qt 5.9, this is broken on Windows and Linux. PR will have to stay open until we update to a newer Qt version. |
selsta
changed the title
selsta
force-pushed
the
menubar3
branch
2 times, most recently
from
f29ef3a
to
8e78e84
Compare
|
This passes CI now, hmm... I wonder if we could merge this now. |
selsta
changed the title
sanderfoobar
approved these changes
Jul 7, 2020
|
Still have to work on adding static linux cmake support to this PR. |
|
Have to add static (linux) support https://invent.kde.org/network/kaidan/-/blob/f597b3f2d587aee8fc93ee2a77a4f7ed08a2dc4c/CMakeLists.txt |
selsta
force-pushed
the
menubar3
branch
2 times, most recently
from
e702039
to
dfb42ba
Compare
|
Fixed all issues now, ready for review. |
xiphon
reviewed
Apr 18, 2021
components/MenuBar.qml
Outdated
| // THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
| import Qt.labs.platform 1.0 as PlatformLabs | ||
| import "../components" as MoneroComponents |
There was a problem hiding this comment.
updated (if that's what you meant)
xiphon
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.