SettingsNode: implement multiple remote nodes support #3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From my tests it seems that the app doesnt remember which node was used last after closing/reopening, currently just falling back to whichever is at the front of the list. It'd be nice if either the last node used was stored persistently or if it were possible to set a default node to be used at startup. |
xiphon
force-pushed
the
multiple-remote-nodes
branch
from
f7ff42e
to
d6212ae
Compare
Updated. |
|
Awesome! |
benevanoff
approved these changes
Apr 4, 2021
selsta
reviewed
Apr 5, 2021
|
Looks a bit broken on first startup if no node has been set previously.
|
xiphon
force-pushed
the
multiple-remote-nodes
branch
from
d6212ae
to
6bc9627
Compare
|
Updated. |
selsta
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1008