-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer: add support for outputs import / export #3435
Conversation
4f3c654
to
25cece9
Compare
25cece9
to
801d161
Compare
@rating89us please review / approve |
I'm getting this error: |
@rating89us how did you get this message? |
On view-only wallet, I clicked the export button. A file browser window opened and I entered a filename, when I clicked on the save button, no file was created and this error message appeared on the console. |
I didn't import monero-project/monero#7678 before testing this PR. Is it included in master? |
It's included in v0.17.2.3 and master. Will test in view only wallet. |
801d161
to
2e18f76
Compare
@rating89us Thanks, found an issue. Updated and was able to export fine now. |
|
2e18f76
to
0ea26f4
Compare
Fixed
Fixed.. had copy paste mistake |
0ea26f4
to
710824c
Compare
Updated one more time to print success / error message. |
710824c
to
0601871
Compare
Now it's working for me. I think we should also print success / error messages for importing/exporting key images. |
0601871
to
36940f0
Compare
Also updated error string here. |
Requires monero-project/monero#7678
Resolves #2816