Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer: add support for outputs import / export #3435

Merged
merged 2 commits into from
Sep 5, 2021

Conversation

selsta
Copy link
Collaborator

@selsta selsta commented Apr 24, 2021

Requires monero-project/monero#7678

Resolves #2816

pages/Transfer.qml Outdated Show resolved Hide resolved
@selsta
Copy link
Collaborator Author

selsta commented Aug 31, 2021

@rating89us please review / approve

@rating89us
Copy link
Contributor

I'm getting this error:
W qrc:/pages/Transfer.qml:1107: TypeError: Type error

@selsta
Copy link
Collaborator Author

selsta commented Sep 2, 2021

@rating89us how did you get this message?

@rating89us
Copy link
Contributor

rating89us commented Sep 2, 2021

On view-only wallet, I clicked the export button. A file browser window opened and I entered a filename, when I clicked on the save button, no file was created and this error message appeared on the console.
I'm using Ubuntu.

@rating89us
Copy link
Contributor

rating89us commented Sep 2, 2021

I didn't import monero-project/monero#7678 before testing this PR. Is it included in master?

@selsta
Copy link
Collaborator Author

selsta commented Sep 2, 2021

I didn't import monero-project/monero#7678 before testing this PR. Is it included in master?

It's included in v0.17.2.3 and master. Will test in view only wallet.

@selsta
Copy link
Collaborator Author

selsta commented Sep 3, 2021

@rating89us Thanks, found an issue. Updated and was able to export fine now.

@rating89us
Copy link
Contributor

  1. Output exporting is working now on view-only wallet. I suggest we add a feedback for the user:
    appWindow.showStatusMessage(qsTr("Outputs successfully exported to file") + translationManager.emptyString, 3);

  2. When importing the outputs file in cold wallet, I get this error:
    W qrc:/pages/Transfer.qml:1121: TypeError: Property 'importOutputsDialog' of object Wallet(0x7f342a9d7b20) is not a function

@selsta
Copy link
Collaborator Author

selsta commented Sep 3, 2021

Output exporting is working now on view-only wallet. I suggest we add a feedback for the user:

Fixed

When importing the outputs file in cold wallet, I get this error:

Fixed.. had copy paste mistake

@selsta
Copy link
Collaborator Author

selsta commented Sep 3, 2021

Updated one more time to print success / error message.

@rating89us
Copy link
Contributor

rating89us commented Sep 3, 2021

Now it's working for me.

I think we should also print success / error messages for importing/exporting key images.

@selsta
Copy link
Collaborator Author

selsta commented Sep 3, 2021

Also updated error string here.

@luigi1111 luigi1111 merged commit 35aee15 into monero-project:master Sep 5, 2021
@selsta selsta deleted the import-export-output branch September 6, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for importing and exporting outputs
4 participants