Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: add _ to end of ttf names of roboto fonts #3753

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

maltejur
Copy link
Contributor

This fixes #2766 by changing the ttf name of Roboto Regular from Roboto-Regular to Roboto-Regular_ with FontForge. This way, if the default system font is Roboto Regular, the FontLoader won't load the system font instead of the provideded one, which apparently leads to issues.

image

This doesn't seem like a clean solution to me, but it does the job and I have no idea what else could solve the issue.

@selsta
Copy link
Collaborator

selsta commented Nov 26, 2021

https://github.com/monero-project/monero-gui/blob/master/qml.qrc#L129
https://github.com/monero-project/monero-gui/blob/master/components/Style.qml#L10

have to be changed too. At this point it make sense to add a _ to all custom fonts to avoid it clashing with system fonts.

@maltejur
Copy link
Contributor Author

have to be changed too

The filename stays the same, what I changed is the name of the font inside the ttf file.

At this point it make sense to add a _ to all custom fonts to avoid it clashing with system fonts

Yeah probably a good idea. I'll also add that.

@selsta
Copy link
Collaborator

selsta commented Nov 26, 2021

The filename stays the same, what I changed is the name of the font inside the ttf file.

Sorry, didn't look properly at the diff :)

@maltejur maltejur changed the title main: Change TTF name of Roboto-Regular to Roboto-Regular_ main: add _ to end of ttf names of roboto fonts Nov 26, 2021
@selsta
Copy link
Collaborator

selsta commented Nov 29, 2021

@rating89us Can you test this on Windows / Linux? Works on Mac for me.

@rating89us
Copy link
Contributor

It's working on Ubuntu and Windows.

@luigi1111 luigi1111 merged commit 4bd7d43 into monero-project:master Dec 2, 2021
@maltejur maltejur deleted the fix_roboto_font branch December 2, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strange font bug
4 participants