Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding translations from Weblate #3832

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

Monero-Weblate
Copy link
Contributor

  • Spanish

    • Miguel Medina
    • jaime diaz
  • Esperanto

    • Dynse Clyde Sacote
    • Robbie Monero
    • Gilberto F da Silva
  • Arabic

    • Malek Atwiz
  • Afrikaans

    • nanostos
  • Polish

    • ambercookie
    • Patix0331
    • Paul Janowitz
  • Icelandic

    • Trendyne
  • Indonesian

    • siptruk
    • tuknag
  • German

    • Marta Kozera
    • Paul Janowitz

@netrik182
Copy link
Contributor

netrik182 commented Feb 4, 2022

Please don't merge this it yet. I downloaded an artifact from CI and some languages (Afrikaans for example) are not showing up.

How can I debug it?

@selsta
Copy link
Collaborator

selsta commented Feb 4, 2022

Check with the latest release first to see if it shows up correctly.

@netrik182
Copy link
Contributor

Confirmed that Afrikaans is not showing on monero-gui-v0.17.3.1-release

@selsta
Copy link
Collaborator

selsta commented Feb 4, 2022

Ok, can you find the first release it's broken?

@netrik182
Copy link
Contributor

Ok, can you find the first release it's broken?

yeah, looking for it.

@selsta
Copy link
Collaborator

selsta commented Feb 4, 2022

Also what percentage is Afrikaans fully translated on weblate?

@netrik182
Copy link
Contributor

netrik182 commented Feb 4, 2022

Also what percentage is Afrikaans fully translated on weblate?

It's 100% translated. First contributions were made on May/21 and last ones (completed) on Aug/21.

Fist commit to include it was this one this is the history https://github.com/monero-project/monero-gui/commits/49cce4de9abf0b6406dee46657f7f9c1b860d866/translations/monero-core_af.ts

@netrik182
Copy link
Contributor

Looks like more languages are missing. We have 45 on Weblate and 35 in GUI. I will share a summary later.

Copy link
Collaborator

@selsta selsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we said on IRC this will need some work before we can merge it, the new languages have to be activated in lang/languages.xml. If you add new icons you also have to add them to qml.qrc.

@netrik182
Copy link
Contributor

netrik182 commented Feb 6, 2022

I just tested the latest CI build (docker-linux-static) and it looks good now. The five languages added are showing on the left panel and strings were properly loaded in GUI.

@netrik182
Copy link
Contributor

Looks like more languages are missing. We have 45 on Weblate and 35 in GUI. I will share a summary later.

Languages added: Afrikaans, Greek, Tamil, Vietnamese and Icelandic

Copy link
Collaborator

@selsta selsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@luigi1111 luigi1111 merged commit 4fba8e6 into monero-project:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants