-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding translations from Weblate #3832
Conversation
Please don't merge this How can I debug it? |
Check with the latest release first to see if it shows up correctly. |
Confirmed that Afrikaans is not showing on monero-gui-v0.17.3.1-release |
Ok, can you find the first release it's broken? |
yeah, looking for it. |
Also what percentage is Afrikaans fully translated on weblate? |
It's 100% translated. First contributions were made on May/21 and last ones (completed) on Aug/21.
|
Looks like more languages are missing. We have 45 on Weblate and 35 in GUI. I will share a summary later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we said on IRC this will need some work before we can merge it, the new languages have to be activated in lang/languages.xml
. If you add new icons you also have to add them to qml.qrc
.
49cce4d
to
f740fd1
Compare
f740fd1
to
08e386f
Compare
I just tested the latest CI build (docker-linux-static) and it looks good now. The five languages added are showing on the left panel and strings were properly loaded in GUI. |
Languages added: Afrikaans, Greek, Tamil, Vietnamese and Icelandic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
Spanish
Esperanto
Arabic
Afrikaans
Polish
Icelandic
Indonesian
German