Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddressBook: fix adding new entry #3865

Merged
merged 1 commit into from
Mar 18, 2022
Merged

AddressBook: fix adding new entry #3865

merged 1 commit into from
Mar 18, 2022

Conversation

selsta
Copy link
Collaborator

@selsta selsta commented Mar 16, 2022 •
edited
Loading

Closes #3866

If currentWallet.addressBook.addRow was successful the code would go into the edit description branch which is not what we want.

@selsta selsta mentioned this pull request Mar 16, 2022
Closed
reemuru
reemuru approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@reemuru reemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested adding and editing new address book entry

@selsta selsta mentioned this pull request Mar 17, 2022
Closed
@Arimfexendrapus
Copy link

thanks for doing this guys, sorry I put it in the wrong place to begin with and then didn't look to see if it was here

@luigi1111 luigi1111 merged commit 002fe8e into monero-project:master Mar 18, 2022
@selsta selsta deleted the addressbook-bug branch March 20, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reemuru reemuru reemuru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adding entry to address book edits description of another entry
4 participants
@selsta @Arimfexendrapus @reemuru @luigi1111