Changed URLs to HTTPS #4045
Merged
Changed URLs to HTTPS #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
moneromooo-monero
approved these changes
Jun 23, 2018
luigi1111
added a commit
that referenced
this pull request
Jul 19, 2018
7cdd147 Changed URLs to HTTPS (einsteinsfool)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runned
grep -rnw . --exclude-dir={external,build} -e 'http:/'in the repo directory and changed all occurrences of "http://" to "https://" if the page was accessible via HTTPS.Sometimes I changed the URL entirely if it was outdated. This was the case for Qt docs,
monerochain.infointree-hash.c.Skipped RFC, licences, epee and gtest.
Checked all URLs manually. There have been some URLs with HTTP that didn't work with HTTPS and I didn't change them. You can check which by pulling my PR and running the grep command from the 1st post. Also, some HTTPS URLs don't work but neither did their HTTP equivalent. They are just outdated and I wasn't able to find a live version for them (as for Qt Docs). I still plan to check all URLs in the repo and find some live versions for dead links, but that's after this PR. And I changed dead URLs to HTTPS too, because why not?