Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epee: use the socket::bind variant which does not throw #4307

Merged
merged 2 commits into from
Sep 14, 2018

Conversation

moneromooo-monero
Copy link
Collaborator

When this throws in a loop, stack trace generation can take
a significant amount of CPU

When this throws in a loop, stack trace generation can take
a significant amount of CPU
@moneromooo-monero
Copy link
Collaborator Author

Plus a fix for binding to the wrong IP.

Copy link
Contributor

@fluffypony fluffypony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@fluffypony fluffypony merged commit 4469b0c into monero-project:master Sep 14, 2018
fluffypony added a commit that referenced this pull request Sep 14, 2018
4469b0c abstract_tcp_server2: fix binding to the wrong IP (moneromooo-monero)
8eab614 epee: use the socket::bind variant which does not throw (moneromooo-monero)
@stoffu stoffu mentioned this pull request Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants